Yeah it’s mad. Tbh I don’t think GitHub PRs are the best workflow, but I absolutely know that git send-email is the worst. I tried to use it once to contribute to OpenSBI, which inexplicably also insists on it. Suffice it to say my patch was never merged…
They wanted me to make some changes and with the normal workflow that’s just git commit and git push. With git send-email I have no fucking idea and it got beyond the point where I had enough cared enough to fight the process.
I would have thought that you fix it locally, git commit, and regenerate the patch set again. Maybe with optional squashing of commits so each patch set doesn’t keep growing.
Oh I see! Thanks. I thought that they deliberately rejected your patch. But it was more about the red tape getting in the way. Yeah, that sounds frustrating.
Yeah it’s mad. Tbh I don’t think GitHub PRs are the best workflow, but I absolutely know that
git send-emailis the worst. I tried to use it once to contribute to OpenSBI, which inexplicably also insists on it. Suffice it to say my patch was never merged…Why didn’t your patch get merged?
They wanted me to make some changes and with the normal workflow that’s just
git commitandgit push. Withgit send-emailI have no fucking idea and it got beyond the point where I had enough cared enough to fight the process.I would have thought that you fix it locally, git commit, and regenerate the patch set again. Maybe with optional squashing of commits so each patch set doesn’t keep growing.
Oh I see! Thanks. I thought that they deliberately rejected your patch. But it was more about the red tape getting in the way. Yeah, that sounds frustrating.