My phone died a few days ago, and the Cisco Duo app overwrote 2FA key backup after connecting my old phone to the internet.
Lemmy has no backup codes, nor can you disable 2FA even while logged in without a valid token.
Anyway, I noticed there’s no rate limiting on 2FA attempts.
So following Lemmy API docs I wrote this exceptionally stupid script (look at my foolish way of parallelization and no auto-stop).
I got the JWT token from logged-in Firefox session, using cookies.txt extension to export it.
Anyway, just make sure your password is secure enough, It’s obviously (potentially) better than 6 digits, probably with 3 valid combinations at each time (current 30s, past 30s, future 30s windows), if I am guessing how it works right.
My attempt also clearly involved a lot of luck with just 21,830 attempts (less than 5 minutes). But, if you’re lucky enough, you may guess it on first attempt, or never if you aren’t.
Anyway, I noticed there’s no rate limiting on 2FA attempts.
Well that’s mildly horrifying… May as well not even have 2fa. Especially with no failed auth attempt notifications (well, no notifications at all really; I hate this part of lemmy)
Glad I don’t have/keep anything private here.
Not do downplay this issue, but based on the description, OP had a valid session cookie, and was updating their profile to disable MFA since they lost the code. They weren’t brute forcing logging in.
I haven’t looked into the source code, maybe this is an instance by instance configuration, but login attempts are rate limited. After a few failed attempts, I started getting this message:
Lemmy Error: You’re being rate limited, wait a bit before trying that again.
I just did a manual test with sh.itjust.works comparing it to lemmy.blahaj.zone.
sh.itjust.works keeps accepting attempts
lemmy.blahaj.zone blocks after I think 3 attempts (I forgot to pay attention)
lemmy.ml also blocks after 3 attemptssh.itjust.works and lemmy.blahaj.zone even use the same version, lemmy.ml is on a 0.19.6 beta.
Going further, lemmy.world: no blocking (as far as tested)
lemm.ee: no blocking (as far as tested)
sopuli.xyz: after 10 attemptsSummary: SDF is using old version, the rate limiting seems to be variable suggesting a setting
Analysis: lemmy.ml, lemmy.blahaj.zone and sopuli.xyz appear to be exposed directly (.zone doesn’t respond without SNI, other 2 show NGINX page). NGINX can pass client IPs in headers. The rate limiting appears to be IP-based.
sh.itjust.works, lemmy.world and lemm.ee are all behind CloudFlare.Hypothesis: Either a problem with passing client IP headers from
cloudflaredor the instance admins simply trust CloudFlare to provide some rate limiting.a problem with passing client IP headers from
cloudflaredI’d be willing to bet this is it. My nginx proxy needs special config to pass client IPs correctly to backend services. Otherwise the backend just sees the IP of the proxying cloudflare server.
proxy_set_header X-Real-IP $http_cf_connecting_ip;
A cloudflare specific header. The typical $remote_addr I use elsewhere has the cloudflare server’s IP when cloudflared is involved.
Right? Holy cow, that’s such poor design.
2FA in lemmy is a gimmick more than anything else, it’s more trouble than it is worth and comes with a significant risk of losing your account. It is better than it used to be but I still wouldn’t consider it good. Best to just not use it.
There’s no rate limit? Astounding security.
If it’s stupid and it works, it’s not stupid.
Good job on tackling this problem in a creative way.
I think I would have given up before reading the documentation & analyzing the code to notice lack of rate limit. Now I’m questioning if 2fa was ever secure with such a limited brute force space
Not rate limited‽
Holy shit that’s one hell of a security oversight
Hell just making it so after 3 failed attempts it can’t be retried for an hour would have made your efforts take over 7000 hours rather than 5 minutes.
I’m really not a fan of 2FA since if I lose or break my phone in most 2FA implementations you just get locked out. Nothing to do. Even with TOTP keys it’s just an extra password I have to remember. I don’t want to do that, the marginal increase doesn’t feel worth the risk of being locked out of my account.
So I just won’t use 2FA, especially on Lemmy of all places. Oh how I’ve heard the horror stories of people using the early 2FA implementation and getting locked out. Not me, not ever, people may say it’s better these days but this still doesn’t seem worth it.
What’s the point of using 2FA on non-crucial accounts anyway? If somebody wants to hack my lemmy account or something, I don’t really care at the end of the day.
There really isn’t any need, it’s very much overkill. I’d say in the vast majority of places where it is asked it is not needed and can even be a bad thing due to the risk of losing account access.
I’m using Aegis Authenticator and I regularly back up my list to an external file uploaded to my NAS. If my phone dies (which has happened before), I can then just restore the list from the backup ¯\_(ツ)_/¯
Companies: we care about your security
Also companies:
This is Lemmy’s 2FA implementation, most of the corporate ones are still not great. Probably not this bad though.
Maybe they were talking about Cisco Duo 2FA app not checking backup age, and just overwriting it with whatever was on device.
Good point, they certainly could’ve been.
Next time save the secret string on a password manager like KeePassXC to syncronize the files to your PC
Yeah! Defeat the dragon of phone 2fa by putting all your secondary passwords on the cloud, synced to your computer! That’ll show em :D
KeePassXC is offline, it uses local storage
If the average case is 20 minutes and you saved 21 minutes doing a less good solution that still worked, you made the right choice.
Hell yeah
This is like the time I forgot the password to my LUKS drive and started brute forcing it using john and a custom password generation function.
I didn’t get nearly as lucky as you, it took around 18 hours, but I got in. Which was lucky since that luks drive had the sole 512 byte key to my long-term storage drive that had important paperwork on it.
